-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use npm and some documentation for troubleshooting iOS development problems #218
Conversation
@@ -17,44 +16,48 @@ https://docs.expo.dev/get-started/set-up-your-environment/ helps you to install | |||
## First time setup | |||
|
|||
```sh | |||
corepack enable # prerequisite to install yarn automatically on next step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to enable corepack on first run, it is not enabled by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? Is npm not installed by default anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm should be installed with every node installation, but corepack still needs to be enabled, as far as I know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the first time I hear that in my years of javascript development. This instance was the first time I ever used corepack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have also never used corepack before, but since it's here already, let's just keep it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I See no reason to include it unless we use an alternative package manager like yarn or pnpm. But If you want to keep it we can also do that, I don't have strong opinions about this and would like to get the pr merged soon.
see discussion in #198 and #189
closes #189